Skip to content

test({solid,svelte}-query): fix incorrect 'describe' name from 'initialData' to match file name#10410

Merged
sukvvon merged 1 commit intomainfrom
test/solid-svelte-query-fix-describe-name
Apr 6, 2026
Merged

test({solid,svelte}-query): fix incorrect 'describe' name from 'initialData' to match file name#10410
sukvvon merged 1 commit intomainfrom
test/solid-svelte-query-fix-describe-name

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 6, 2026 •
edited by coderabbitai bot
Loading

🎯 Changes

  • Fix describe('initialData') to describe('useQuery') in solid-query/useQuery.test-d.tsx
  • Fix describe('initialData') to describe('createQuery') in svelte-query/createQuery.test-d.ts
  • The top-level describe should match the file name, with initialData as a nested describe inside

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Updated internal test suite labels for improved clarity and organization.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dec8a44d-8197-46cc-826c-cbeb0a66ac42

📥 Commits

Reviewing files that changed from the base of the PR and between a8dc3b7 and 80876be.

📒 Files selected for processing (2)
  • packages/solid-query/src/__tests__/useQuery.test-d.tsx
  • packages/svelte-query/tests/createQuery.test-d.ts
📝 Walkthrough

Walkthrough

Type-test suite labels were updated across two packages to reflect the actual functions being tested. In packages/solid-query/src/__tests__/useQuery.test-d.tsx, the describe block changed from initialData to useQuery. In packages/svelte-query/tests/createQuery.test-d.ts, it changed from initialData to createQuery. No logic or assertions were modified.

Changes

Cohort / File(s) Summary
Type Test Suite Labels
packages/solid-query/src/__tests__/useQuery.test-d.tsx, packages/svelte-query/tests/createQuery.test-d.ts		 Updated describe block labels from generic initialData to specific function names (useQuery, createQuery) for clarity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

package: svelte-query, package: solid-query

Poem

🐰 Labels renamed, now they shine,
Tests describe what they define,
useQuery and createQuery too,
No longer hiding "initialData" blue! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing describe block names from 'initialData' to match the actual file names ('useQuery' and 'createQuery') in two test files.
Description check ✅ Passed The description covers all required sections with complete information about the changes, checklist items, and release impact. The author clearly explains what was fixed and marked it as dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/solid-svelte-query-fix-describe-name

Comment @coderabbitai help to get the list of available commands and usage tips.

@sukvvon sukvvon self-assigned this Apr 6, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 6, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 80876be

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-06 14:01:23 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 6, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10410

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10410

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10410

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10410

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10410

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10410

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10410

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10410

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10410

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10410

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10410

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10410

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10410

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10410

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10410

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10410

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10410

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10410

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10410

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10410

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10410

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10410

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10410

commit: 80876be

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

size-limit report 📦

Path Size
react full 11.98 KB (0%)
react minimal 9.01 KB (0%)

@sukvvon sukvvon merged commit fc35bbf into main Apr 6, 2026
10 checks passed
@sukvvon sukvvon deleted the test/solid-svelte-query-fix-describe-name branch April 6, 2026 14:03
This was referenced Apr 6, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

package: solid-query package: svelte-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon